-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat: Support program parameter in attach configurations (#14046) #14108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Support program parameter in attach configurations (#14046) #14108
Conversation
|
@Subham-KRLX It looks like there are compile errors: src/Debugger/configurationProvider.ts(361,40): error TS2339: Property 'findProcessByProgramName' does not exist on type 'DebugConfigurationProvider'. |
Move the findProcessByProgramName private method from ConfigurationSnippetProvider class to DebugConfigurationProvider class where it belongs and is called. This fixes: - TS2339: Property 'findProcessByProgramName' does not exist on type 'DebugConfigurationProvider' - TS6133: 'findProcessByProgramName' is declared but its value is never read
|
@sean-mcmanus We've resolved both compilation errors by moving the findProcessByProgramName method to the correct location inside the DebugConfigurationProvider class. The fix has been committed and pushed to the feature/attach-by-program-name branch. The TypeScript compilation errors are now resolved. |
|
@sean-mcmanus I just want to add that I am also really interested in this feature. It seems to have been sitting for over a month waiting for a review, so I'm bumping this in case people forgot. |
sean-mcmanus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are there Code Sample changes? Can you remove those? Aren't those changes in a separate PR already?
Why is there an MIEngine_Debug subproject added? Can that be removed?
Fixes #14046
Add support for program parameter in attach configurations to attach to processes by executable name, similar to LLDB extension.
Example:
json
{
"type": "cppvsdbg",
"request": "attach",
"program": "myprogram.exe"
}
Automatically finds matching process, prompts if multiple matches. Backward compatible with existing processId configurations.