feat(compat): Bump Gradle Wrapper to v8.5 and change Java 21 min Gradle version#1455
Merged
jdneo merged 4 commits intomicrosoft:developfrom Dec 6, 2023
Merged
Conversation
JoseLion
commented
Nov 30, 2023
Member
|
Thank you @JoseLion! I will look at this soon! |
Member
|
Would you mind also updating the check here: |
Contributor
Author
|
Good catch! I didn't know there was a compatibility check there. I updated the check 👍🏼 |
jdneo
reviewed
Dec 5, 2023
...t.gradle.bs.importer/src/com/microsoft/gradle/bs/importer/GradleBuildServerBuildSupport.java
Outdated
Show resolved
Hide resolved
jdneo
approved these changes
Dec 6, 2023
Member
jdneo
left a comment
jdneo
left a comment
There was a problem hiding this comment.
LGTM.
I appended a commit to update the target platform because I found the old one is invalid now.
Member
|
Thank you @JoseLion for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up of #1419 to update the Gradle Wrapper to v8.5, which supports running Gradle on Java 21. Additionally, it addresses the
TODOcomment left behind inUtils.getLowestGradleVersion(..)method to use v8.5 as the minimum Gradle version for Java 21 (instead of v8.4).