enhancement - add groupId, artifactId and version attributes#1620
enhancement - add groupId, artifactId and version attributes#1620jdneo merged 3 commits intomicrosoft:developfrom
Conversation
|
Hi @jdneo, I was wondering where should I write the test for this change? |
|
We don't have tests for this module right now. I would be great if you would like to add some, but it won't block this PR to be merged. We can do it in another PR. BTW, since this is a plugin of the JDT.LS, which uses OSGi for build, adding test cases might be a little bit complex. |
...t.gradle.bs.importer/src/com/microsoft/gradle/bs/importer/GradleBuildServerBuildSupport.java
Outdated
Show resolved
Hide resolved
|
Hi @mamilic, After this PR merged, do you need me to publish a pre-release which includes this change for the purpose of Java Projects view integration? |
|
Hi @jdneo , that would be awesome, then I can work on Java Projects View. Thanks! |
|
@mamilic I plan to merge this PR after 3.17.0 is released. Currently there is some regression happens at the build server side. I may need to revert some changes which may take some time. |
|
Hi @jdneo , if you have time please let me know when pre-release is available with this changes included. |
2 participants
This relates to, microsoft/vscode-java-dependency#857