Skip to content

Add save participant under its own ID to avoid conflicts.#1649

Merged
jdneo merged 2 commits intomicrosoft:developfrom
rgrunber:fix-save-participant
Mar 5, 2025
Merged

Add save participant under its own ID to avoid conflicts.#1649
jdneo merged 2 commits intomicrosoft:developfrom
rgrunber:fix-save-participant

Conversation

@rgrunber
Copy link
Contributor

@rgrunber rgrunber commented Mar 3, 2025

CC'ing @jdneo , @Eskibear for a better idea if this seems reasonable. From my testing, this improve performance by avoiding re-indexing all libraries every time.

- 'org.eclipse.jdt.core' has its own save participant which fails to run
  and produces "symptoms" like re-indexing all libraries on every
  project import

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
Copy link
Member

@jdneo jdneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! It looks good to me.

There are some issues for the ci pipeline. I'll update the pipeline first

@jdneo jdneo merged commit 6c31daa into microsoft:develop Mar 5, 2025
5 checks passed
@jdneo
Copy link
Member

jdneo commented Mar 5, 2025

@rgrunber There are some issue with our build pipeline recently. I'll make a nightly release once the issue is solved, and a stable one after that.

@rgrunber rgrunber deleted the fix-save-participant branch March 5, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants