Fix a project's name if there are modules with the same name#1687
Merged
jdneo merged 2 commits intomicrosoft:developfrom Aug 6, 2025
Merged
Fix a project's name if there are modules with the same name#1687jdneo merged 2 commits intomicrosoft:developfrom
jdneo merged 2 commits intomicrosoft:developfrom
Conversation
chagong
reviewed
Aug 5, 2025
| for (Entry<URI, List<BuildTarget>> entrySet : buildTargetMap.entrySet()) { | ||
| URI uri = entrySet.getKey(); | ||
| String projectName = new File(uri).getName(); | ||
| if (projectNames.contains(projectName)) { |
Contributor
There was a problem hiding this comment.
In case of big number of projects, is it better to use hashset for both projectNames and duplicatedProjectNames?
Contributor
Author
There was a problem hiding this comment.
Yes, it is. I have updated the PR.
chagong
approved these changes
Aug 6, 2025
jdneo
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1659
The PR adds the parent folder name to the project name if there are duplicate module names.
@ramazangirgin-check24 As to the reported circular dependencies, these messages are just a warning. You can ignore them.
The related issue - redhat-developer/vscode-java#718
Test project: testproject.zip
Test vsix:
https://github.com/snjeza/vscode-test/raw/refs/heads/master/vscode-gradle-3.17.4.vsixhttps://github.com/snjeza/vscode-test/raw/refs/heads/master/vscode-gradle-3.17.5.vsixWithout the PR:
With the PR: