Comments don't show when PR is on non-default repo

[travisdowns]

When I make a PR to a repo that is also the default repo (the repo the "from" repo in the PR was forked from), I can see the comments in the associated PR "inline" in the editors (and also in the comments window) when that branch is checked out. Great!

However, this does not work when I'm submitting a PR to a repo that is not the default in the sense above. To be specific, we have repo "A" which is the the orginal repo for some project. There is a GH fork of this repo, repo "B" (under an organization), and then my own fork of "B", call it "C" under my user. Specifically "A" is this, "B" is this and "C" is this.

My workload is that I have all three configured as remotes, and I always push my feature branches to "C" and from there I open pull requests against "A" or "B" but most often "A". When I open them against "B", comments for the PRs show fine, but against "A" they do not. I can still see the PRs in the "Created by me" list in the GH PR extension sidebar, but not by default (I have to click "continue fetching from other remotes" once). I can see the contents of the PR in that view, open diffs, etc, but the comments do not show inline in the editable view of the same files even when the PR branch is checked out locally.

If I right click "Checkout pull request" from the GH PR menu, then the comments do appear inline, but now I'm not on my local branch any more but a pr/* style branch like pr/travisdowns/3068.

• Extension version: 0.120.1
• VSCode Version: 1.105.1
• OS: Ubuntu 22.04 and 24.04
• Repository Clone Configuration (single repository/fork of an upstream repository):
• GitHub Product (GitHub.com/GitHub Enterprise version x.x.x): github.com

Steps to Reproduce:

1. As above

[alexr00]

A few questions:

• What is the output of running git remote -v?
• What do you have the setting githubPullRequests.remotes configured to?

[travisdowns]

Thanks @alexr00 for the reply. Here's the output:

$ git remote -v
redpanda        https://github.com/redpanda-data/seastar (fetch)
redpanda        https://github.com/redpanda-data/seastar (push)
scylladb        https://github.com/scylladb/seastar (fetch)
scylladb        https://github.com/scylladb/seastar (push)
tdowns  https://github.com/travisdowns/seastar (fetch)
tdowns  https://github.com/travisdowns/seastar (push)
upstream        https://github.com/redpanda-data/seastar.git (fetch)
upstream        https://github.com/redpanda-data/seastar.git (push)

    "githubPullRequests.remotes": [
        "scylladb",
        "upstream",
        "tdowns",
        "redpanda"
    ],

Note that in the context of this issue, "A" is scylladb (where I open the PR), "B" is redpanda (B is forked from A), and "C" is tdowns (where I push my local branch and the source of the PR branch).

Note that if I open a PR against "B" (redpanda) (from "C", as before), then things do work if I apply the workaround of syncing up the state by clicking publish as discussed in #7997 .

[alexr00]

I am suspicious of the two remotes, upstream and redpanda that both point to https://github.com/redpanda-data/seastar.

I'll try a full 3 repo setup and see if I can repro.

[travisdowns]

I am suspicious of the two remotes, upstream and redpanda that both point to https://github.com/redpanda-data/seastar.

Admittedly this is a bit weird but this is pretty consistent for me even on other hosts where I don't have this weird config, if it doesn't repro for you I can work on a clean repro w/o duplicate remotes.

[alexr00]

I wasn't able to reproduce your exact issue, but I saw something similar. The bug is that we don't handle having the same remote with different names properly. The fix will be available in the pre-release version of the extension later this week, probably Thursday afternoon or evening.

[alexr00]

Thank you for all the great information!