Support readMemory/writeMemory from debuggers

[connor4312]

Similar: microsoft/vscode-hexeditor#70

[jasonwilliams]

This would be very cool

[connor4312]

DAP has support for readMemory requests which would do what we need in a generic way. However, we don't use it in vscode yet. I think either adding support for it in core, or having the hex editor extension use the DebugAdapterTracker to support memory requests itself--which can add context menu actions and so on--is the way to go.

cc @weinand @isidorn @lramos15

[weinand]

@connor4312 I wonder whether we should align the work on a "Memory View" with the current work on the "Disassembly View" (see #124163 and the corresponding PR #125737).
Reason being: a "Disassembly" view could be considered as just another representation of a "Memory" view.

In addition, I'm currently working on the spec for the "writing" side and change notifications of DAP's memory feature. You might want to chime in on the spec discussions.

[lramos15]

I would be happy to help with the hex editor side if need be. Although the hex editor being an external extension might feel out of place if we have a disassembly view in one case and a hex extension in another.

[connor4312]

I think disassembly is mostly separate as far as implementation goes. Visually the left side of the disassembly table is similar, but it doesn't need the "editor" part of the hex editor -- static raw display is rather trivial.

👍 on getting the writing side going! Left a couple comments

[connor4312]

Update here: now that we have a full set of read/writeMemory in DAP, we should implement this in a generic way for all debuggers who implement these methods.

I think it makes sense to deduplicate the hex editor -- either implementing an editor for binary data core, or using the hex editor for DAP read/write memory. @lramos15 @roblourens any thoughts on this?

[roblourens]

I like using the hex editor to do this. We just have some data that we want to edit, we can launch an appropriate editor to edit it. Maybe that's the hex editor by default, then if it represents text, I could open it in the text editor. If it represents an image, I can open it in an image editor. Is that possible?

[lramos15]

I guess the question becomes how does this work if it takes a bunch of dependencies on non built-in extensions

[roblourens]

Let's build it in 😄