Terminals launched with invalid paths hang during creation and never emit onExit

[azydevelopment]

• VSCode Version: Code 1.14.2 (cb82feb, 2017-07-19T23:34:09.706Z)
• OS Version: Windows_NT ia32 10.0.15063
• Extensions:

Extension	Author (truncated)	Version
cpptools	ms-	0.12.1
csharp	ms-	1.11.0

---

Steps to Reproduce:

1. Open an empty folder with VSCode
2. Configure a new MSBuild task
3. Try building (execute task)

Expected: Fails gracefully somehow
Actual: Just spins forever and never dies until I manually kill the task.

Note: this also happens when I mistype a path or something in the command to a directory that say for example doesn't exist. If the command is wrong in some way, the task will just spin forever.

Reproduces without extensions: Yes/No

[dbaeumer]

The terminal doesn't send an onExit or any other event in this case so that the task system could determine that the process has finished / died. Steps to reproduce:

• Windows, no msbuild installed
• fresh workspace
• configure task runner
• select MSBuild from the list of templates
• F1 > Run Task > Select Build

Observe: the spinner never stops. Could can't even terminate the task.

The reason is that the shell actually fails to execute msbuild however the terminal never send an onExit event. Look at the process explorer there is a lingering vscode process of --type=terminal

[Tyriar]

I upgraded to node-pty@0.7.0 which may improve the problem, if not I'd guess this is related towinpty is not terminating the processes correctly.

[dbaeumer]

I retested this and it is still happening under Insider today.

[Tyriar]

terminalProcess stalls on this native call: https://github.com/Tyriar/node-pty/blob/a1d161cba7396849116b94d8fa6bb0041a9a7ea6/src/win/pty.cc#L87, meaning this function never returns https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/terminal/node/terminalProcess.ts#L47

Not sure why a Node.js or native exception isn't happening.