[typescript-language-features] Expandable hover#228255
Merged
mjbvz merged 6 commits intomicrosoft:mainfrom Sep 24, 2024
Merged
Conversation
mjbvz
previously approved these changes
Sep 13, 2024
amunger
previously approved these changes
Sep 13, 2024
mahfuztbt
approved these changes
Sep 15, 2024
Collaborator
|
@gabritto Should we merge this for testing? If you prefer we can gate this behind an experimental setting too |
Member
Author
As discussed offline, I'll implement the missing part of detecting when expansion is possible or not (both in this PR and on the TSServer PR), and then we can merge this for testing. @mjbvz can you point me to how to add a vscode setting to gate this? |
Collaborator
|
Thanks @gabritto. For the setting, try taking a look at vscode.workspace.getConfiguration('typescript').get('experimental.expandableHover'); |
mjbvz
approved these changes
Sep 23, 2024
roblourens
approved these changes
Sep 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeScript counterpart: microsoft/TypeScript#59940
See description of the TS PR for what's currently supported.