Use relative path for extension#3224
Merged
Merged
Conversation
In the Firefox repository, we avoid vendoring windows-rs because it's big, and instead pull it some other way. Because cargo doesn't support this kind of setup, we have a fake windows-rs crate that uses the modules from where the real windows-rs is. This falls short when the WindowsAndMessaging feature is enabled because CARGO_MANIFEST_DIR doesn't point to the real windows-rs.
kennykerr
approved these changes
Aug 27, 2024
kennykerr
left a comment
kennykerr
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, I'd like to get rid of include_ext entirely but this seems like a reasonable change for the time being.
kennykerr
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the Firefox repository, we avoid vendoring windows-rs because it's big, and instead pull it some other way. Because cargo doesn't support this kind of setup, we have a fake windows-rs crate that uses the modules from where the real windows-rs is. This falls short when the WindowsAndMessaging feature is enabled because CARGO_MANIFEST_DIR doesn't point to the real windows-rs.