Skip to content

Add thread globals for downloader thread#6141

Merged
JohnMcPMS merged 1 commit intomicrosoft:masterfrom
Trenly:MOTWLog
Apr 14, 2026
Merged

Add thread globals for downloader thread#6141
JohnMcPMS merged 1 commit intomicrosoft:masterfrom
Trenly:MOTWLog

Conversation

@Trenly
Copy link
Copy Markdown
Contributor

@Trenly Trenly commented Apr 13, 2026


Microsoft Reviewers: Open in CodeFlow

@Trenly Trenly requested a review from a team as a code owner April 13, 2026 21:33
@JohnMcPMS
Copy link
Copy Markdown
Member

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@Trenly
Copy link
Copy Markdown
Contributor Author

Trenly commented Apr 14, 2026

@JohnMcPMS - Should I also fix these (separately) ?

  1. TerminationSignalHandler::m_windowThread — WindowMessageProcedure uses AICLI_LOG for shutdown events (WM_QUERYENDSESSION, WM_CLOSE), but the window thread has no globals set
  2. ServerShutdownSynchronization::m_shutdownThread — SynchronizeShutdown uses AICLI_LOG 4× for Verbose shutdown phase logging, but the thread has no globals set

@JohnMcPMS
Copy link
Copy Markdown
Member

@JohnMcPMS - Should I also fix these (separately) ?

  1. TerminationSignalHandler::m_windowThread — WindowMessageProcedure uses AICLI_LOG for shutdown events (WM_QUERYENDSESSION, WM_CLOSE), but the window thread has no globals set
  2. ServerShutdownSynchronization::m_shutdownThread — SynchronizeShutdown uses AICLI_LOG 4× for Verbose shutdown phase logging, but the thread has no globals set

Those are more useful for the COM server, which I believe sets a global file logger that will catch them.

@JohnMcPMS JohnMcPMS merged commit 438b642 into microsoft:master Apr 14, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants