Skip to content

Add New Version of Cloudflare Warp and Use New Download URL #236466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
microsoft-github-policy-service merged 2 commits into from
Mar 11, 2025
Merged

Add New Version of Cloudflare Warp and Use New Download URL #236466

microsoft-github-policy-service merged 2 commits into from
Mar 11, 2025

Conversation

@rmulleyjc
Copy link
Contributor

@rmulleyjc rmulleyjc commented Mar 10, 2025 •
edited by microsoft-github-policy-service bot
Loading

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.9 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

wingetbot commented Mar 10, 2025

Service Badge  Service Badge  

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Author-Feedback This needs a response from the author. Manifest-Path-Error This label indicates that the PR was not placed in the manifest folder. Needs-Attention This work item needs to be reviewed by a member of the core team. labels Mar 10, 2025
@wingetbot
Copy link
Collaborator

wingetbot commented Mar 10, 2025

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Manifest-Path-Error This label indicates that the PR was not placed in the manifest folder. Needs-Attention This work item needs to be reviewed by a member of the core team. Needs-Author-Feedback This needs a response from the author. Project-File labels Mar 10, 2025
@wingetbot
Copy link
Collaborator

wingetbot commented Mar 10, 2025

Possible duplicate package entry.

Similar installer SHA256 hash found in manifest:

  • InstallerSha256: 5d3d2fcca081de37a4ccfd8b29d7420cef852b6171973c4f047c96731e1dd566
    • manifests\c\Cloudflare\Warp\25.1.861.0

@wingetbot
Copy link
Collaborator

wingetbot commented Mar 10, 2025

=== manifests\c\Cloudflare\Warp\2025.1.861.0 ===
Missing Properties value based on version 25.1.861.0:

  • Author
  • LicenseUrl
  • Copyright
  • CopyrightUrl
  • Tags
  • Platform
  • InstallModes
  • ProductCode
  • Dependencies
  • AppsAndFeaturesEntries

@wingetbot wingetbot added Possible-Duplicate Manifest-Metadata-Consistency New-Manifest Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Mar 10, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot enabled auto-merge (squash) March 10, 2025 20:26
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit bb50a4c into microsoft:master Mar 11, 2025
2 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Mar 11, 2025
@wingetbot
Copy link
Collaborator

wingetbot commented Mar 11, 2025

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

kachick
kachick reviewed Mar 11, 2025
View reviewed changes
manifests/c/Cloudflare/Warp/2025.1.861.0/Cloudflare.Warp.installer.yaml
Comment on lines +15 to +16
InstallerUrl: https://downloads.cloudflareclient.com/v1/download/windows/version/2025.1.861.0
InstallerSha256: 5D3D2FCCA081DE37A4CCFD8B29D7420CEF852B6171973C4F047C96731E1DD566
Copy link
Contributor

@kachick kachick Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use New Download URL

Same installer of

winget-pkgs/manifests/c/Cloudflare/Warp/25.1.861.0/Cloudflare.Warp.installer.yaml

Lines 28 to 29 in 66d215b

InstallerUrl: https://downloads.cloudflareclient.com/v1/download/windows/version/2025.1.861.0
InstallerSha256: 5D3D2FCCA081DE37A4CCFD8B29D7420CEF852B6171973C4F047C96731E1DD566
?

Copy link
Contributor

@kachick kachick Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted in #236604

I hope this package will be a candidate in #29323. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stephengillie stephengillie stephengillie approved these changes

+1 more reviewer

@kachick kachick kachick left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR New-Manifest Publish-Pipeline-Succeeded Validation-Completed Validation passed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rmulleyjc @wingetbot @kachick @stephengillie