Skip to content

Remove script to bump version + Change commit messages for generation PRs(PHP)#1237

Merged
SilasKenneth merged 2 commits intodevfrom
chore/remove-php-bump-version-script-call
May 28, 2024
Merged

Remove script to bump version + Change commit messages for generation PRs(PHP)#1237
SilasKenneth merged 2 commits intodevfrom
chore/remove-php-bump-version-script-call

Conversation

@SilasKenneth
Copy link
Copy Markdown
Member

@SilasKenneth SilasKenneth commented May 27, 2024

Summary

  • Removes the step to bump version during PHP SDK generation.
  • Change commit message to align with release-please commit message format.

Generated code differences

Pull requests that result in changes to generated code and/or directory structures should include example diffs of the resulting changes. This makes code review much easier.

Command line arguments to run these changes

Provide the command line arguments here so that reviewers can quickly repro the results of changes.

Links to issues or work items this PR addresses

Microsoft Reviewers: Open in CodeFlow

@SilasKenneth SilasKenneth self-assigned this May 27, 2024
@SilasKenneth SilasKenneth requested a review from a team as a code owner May 27, 2024 12:41
@SilasKenneth SilasKenneth merged commit b549e4c into dev May 28, 2024
@SilasKenneth SilasKenneth deleted the chore/remove-php-bump-version-script-call branch May 28, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants