Merged
Conversation
zengin
suggested changes
Oct 1, 2020
Contributor
There was a problem hiding this comment.
E2E logic makes sense.
Waiting on:
- Are return type changes breaking?
- Decision from microsoft/Vipr#147 (comment), in case it requires changes in this repository.
Templates/Java/requests_extensions/BaseEntityCollectionWithReferencesRequest.java.tt
Show resolved
Hide resolved
Templates/Java/requests_extensions/BaseEntityCollectionWithReferencesRequest.java.tt
Show resolved
Hide resolved
Member
Author
|
@zengin thanks for the great feedback! replied to both. |
MIchaelMainer
previously approved these changes
Oct 2, 2020
zengin
suggested changes
Oct 2, 2020
Contributor
zengin
left a comment
zengin
left a comment
There was a problem hiding this comment.
- tests need the same updates
Member
Author
yep, I just saw that, on it :) |
Member
Author
|
@zengin I actually had forgotten a file in my last commit 🤦♂️ |
zengin
approved these changes
Oct 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for odata casting in Java (and more generally in typewriter) by leveraging drived type constraints annotations.
replaces #302
links
https://github.com/oasis-tcs/odata-vocabularies/blob/master/vocabularies/Org.OData.Validation.V1.xml#L147
https://docs.microsoft.com/en-us/odata/webapi/built-in-routing-conventions
Generated code differences
microsoftgraph/msgraph-sdk-java#509