Skip to content

GraphResponse object#112

Merged
andrueastman merged 1 commit intofeature/2.0from
andrueastman/GraphResponse
Apr 29, 2020
Merged

GraphResponse object#112
andrueastman merged 1 commit intofeature/2.0from
andrueastman/GraphResponse

Conversation

@andrueastman
Copy link
Contributor

@andrueastman andrueastman commented Apr 22, 2020

This PR adds support for the GraphResponse object which will act as a wrapper for properties like the status code and http headers.

This work is done according to the spec found here.
https://github.com/microsoftgraph/msgraph-sdk-design/blob/master/GraphResponse.md

Currently, a user should be able to follow the following flow

BaseClient client = new BaseClient(requestUrl, authenticationProvider, customHttpProvider);
BaseRequest baseRequest = new BaseRequest(requestUrl, client);

GraphResponse<TestUser> returnedResponse = await baseRequest.SendAsyncWithGraphResponse<TestUser>("string", CancellationToken.None);
TestUser user = await response.GetResponseObjectAsync();

Fixes AB#4600

@andrueastman andrueastman force-pushed the andrueastman/GraphResponse branch from 5fec32b to a150479 Compare April 22, 2020 10:47
@andrueastman andrueastman marked this pull request as ready for review April 22, 2020 10:47
@andrueastman andrueastman self-assigned this Apr 22, 2020
@andrueastman andrueastman linked an issue Apr 22, 2020 that may be closed by this pull request
@andrueastman andrueastman added this to the 2.0.0 milestone Apr 22, 2020
@ddyett ddyett requested a review from zengin April 28, 2020 17:51
@andrueastman andrueastman merged commit 6ae4d2c into feature/2.0 Apr 29, 2020
@andrueastman andrueastman deleted the andrueastman/GraphResponse branch April 29, 2020 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create response object to wrap entire response

2 participants