Skip to content

Conversation

@baywet
Copy link
Member

@baywet baywet commented Oct 1, 2020

@baywet baywet added this to the 2.3.0 milestone Oct 1, 2020
@baywet baywet self-assigned this Oct 1, 2020
Copy link
Contributor

@zengin zengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please provide a description

@baywet
Copy link
Member Author

baywet commented Oct 2, 2020

@zengin yep, sorry, this one was created before our last discussion

@baywet baywet requested a review from zengin October 2, 2020 18:31
@baywet baywet merged commit 7490725 into dev Oct 2, 2020
@baywet baywet deleted the feature/pom-placeholder branch October 2, 2020 18:53
@MIchaelMainer
Copy link
Collaborator

Does this mean that you have to manually update the pom.xml whenever you make a change to the dependencies or is there a tool/script to do this?

@baywet
Copy link
Member Author

baywet commented Oct 2, 2020

manual at this point, but again this is only used for the dependency tree of GitHub. This way GitHub is able to tell "oh this repo actually publishes a lib, let's see what it depends on and what depends on it to build the tree". Worst case if we forget to update it, our dependency tree will be inaccurate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants