Add module-info.java as multi release jar#8
Merged
micycle1 merged 1 commit intomicycle1:masterfrom Sep 27, 2023
ClaasJG:master
Merged
Add module-info.java as multi release jar#8micycle1 merged 1 commit intomicycle1:masterfrom ClaasJG:master
micycle1 merged 1 commit intomicycle1:masterfrom
ClaasJG:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi and thanks for your porting effort.
This pull request adds a
module-info.javafile whichallows an user to use the library as java module named
clipper2with jigsaw. It uses the multi release feature, hence should still be valid for an java 8 environment.An alternative to this pull request could be an
Automatic-Module-Namemanifest entry.I think this pull request is non disruptive and the better way, but the manifest solution would be simpler and in the end there would be little difference from the library user point of view.
Have a nice day
-ClaasJG