Skip to content

Fix configure and Makefile#756

Merged
vyzo merged 3 commits into
masterfrom
fix-configure
Aug 6, 2023
Merged

Fix configure and Makefile#756
vyzo merged 3 commits into
masterfrom
fix-configure

Conversation

@vyzo

@vyzo vyzo commented Aug 6, 2023

Copy link
Copy Markdown
Collaborator

The thing was flat out broken; instead of installing under prefix it installed under prefix/gerbi/something and linked the binaries. This is the wrong thing to do: when the user says prefix he means prefix, not some random directory underneath.

@vyzo vyzo requested review from drewc and ober August 6, 2023 19:39
@vyzo vyzo changed the title Fix configure Fix configure and Makefile Aug 6, 2023
@ober

ober commented Aug 6, 2023

Copy link
Copy Markdown
Collaborator

tested in docker. all works as expected.

@ober ober left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected

@vyzo vyzo merged commit 7fd4a28 into master Aug 6, 2023
@vyzo vyzo deleted the fix-configure branch August 6, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants