Skip to content

fix: update warning message during kitten generation if path contains whitespace #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikesmithgh merged 1 commit into from
Dec 31, 2024
Merged

fix: update warning message during kitten generation if path contains whitespace #296

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 22 additions & 10 deletions lua/kitty-scrollback/api.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,14 +93,33 @@ M.generate_kittens = function(generate_modes)
':p'
)

local action_alias = 'kitty_scrollback_nvim'
local alias_config = {
'# kitty-scrollback.nvim Kitten alias',
'action_alias ' .. action_alias .. ' kitten ' .. kitty_scrollback_kitten,
'',
}
local alias_config_quoted = ([[action_alias %s kitten '%s']]):format(
action_alias,
kitty_scrollback_kitten
)

local alias_warn = {}
if kitty_scrollback_kitten:find('%s') then
alias_warn = {
[[# WARNING]],
[[# ']] .. kitty_scrollback_kitten .. [[' contains whitespace.]],
[[# You may receive an error opening kitty-scrollback.nvim. If an error occurs, you can]],
[[# workaround this issue by symlinking the kitty-scrollback.nvim plugin directory to]],
[[# Kitty's configuration directory with the command:]],
[[#]],
[[# If you are using Kitty version 0.38.2 or greater, then whitespace is allowed in the]],
[[# path and you can ignore this warning. Just make sure that the kitten path is]],
[[# wrapped in quotes. For example,]],
[[#]],
[[# ]] .. alias_config_quoted,
[[#]],
[[# If you are using Kitty version 0.38.1 or less, then you may receive an error opening]],
[[# kitty-scrollback.nvim. If an error occurs, you can workaround this issue by symlinking]],
[[# the kitty-scrollback.nvim plugin directory to Kitty's configuration directory with]],
[[# the command:]],
[[#]],
[[# ln -s ']]
.. vim.fn.fnamemodify(kitty_scrollback_kitten, ':h:h')
Expand All @@ -118,13 +137,6 @@ M.generate_kittens = function(generate_modes)
}
end

local action_alias = 'kitty_scrollback_nvim'
local alias_config = {
'# kitty-scrollback.nvim Kitten alias',
'action_alias ' .. action_alias .. ' kitten ' .. kitty_scrollback_kitten,
'',
}

local builtin_map_configs = {
'# Browse scrollback buffer in nvim',
'map kitty_mod+h ' .. action_alias,
Expand Down