Repository navigation
[io] Raise a clear error for a line or block whose geometry can not be resolved - #2202
Merged
felixdittrich92 merged 1 commit intoOct 30, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2202 +/- ##
==========================================
+ Coverage 97.75% 97.77% +0.01%
==========================================
Files 170 170
Lines 10974 10979 +5
==========================================
+ Hits 10728 10735 +7
+ Misses 246 244 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Block()takes only optional arguments, but without any line or artefact (and nogeometry) it raised a bareIndexError: list index out of rangewhile resolving its geometry from its first child.Line([])did the same, after aMean of empty slicewarning from its objectness score.Both now raise a
ValueErrorsaying that the geometry can not be resolved and should be passed. Elements with children, or with an explicit geometry, are unchanged