Repository navigation
[datasets] Encode an empty batch of sequences in encode_sequences - #2210
Merged
felixdittrich92 merged 1 commit intoNov 2, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2210 +/- ##
==========================================
- Coverage 97.76% 97.75% -0.02%
==========================================
Files 170 170
Lines 10982 10986 +4
==========================================
+ Hits 10737 10739 +2
- Misses 245 247 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without a target_size (or with dynamic_seq_length=True), encode_sequences computes the length from
max(len(w) for w in sequences), which raises "max() iterable argument is empty" for an empty list. With a fixed
target_size an empty list already gives an empty (0, target_size) array. It now gives an empty (0, 1) array in
the other case too, instead of crashing. Two cases added to the existing parametrized test.