Add mcl_sign support (fixes #330)#419
Merged
BuckarooBanzay merged 2 commits intominetest-mapserver:masterfrom Apr 19, 2025
Merged
Add mcl_sign support (fixes #330)#419BuckarooBanzay merged 2 commits intominetest-mapserver:masterfrom
BuckarooBanzay merged 2 commits intominetest-mapserver:masterfrom
Conversation
BuckarooBanzay
approved these changes
Apr 19, 2025
Member
BuckarooBanzay
left a comment
There was a problem hiding this comment.
a bit repetitive but works for me 👍
Pull Request Test Coverage Report for Build 14501569459Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please squash if you accept this pull request. This adds Mineclonia signs (mcl_signs) support based on the comments in the issue this (fixes #330). It was done in a lazy manner and does not loop over all possible signs that could exist if new woods be defined or additional mods, and just reuses the wood sign image.
Tested on MTG and Mineclonia worlds' maps.