Skip to content

Add mcl_sign support (fixes #330)#419

Merged
BuckarooBanzay merged 2 commits intominetest-mapserver:masterfrom
bgstack15:dev/add-mcl-signs
Apr 19, 2025
Merged

Add mcl_sign support (fixes #330)#419
BuckarooBanzay merged 2 commits intominetest-mapserver:masterfrom
bgstack15:dev/add-mcl-signs

Conversation

@bgstack15
Copy link
Copy Markdown
Contributor

Please squash if you accept this pull request. This adds Mineclonia signs (mcl_signs) support based on the comments in the issue this (fixes #330). It was done in a lazy manner and does not loop over all possible signs that could exist if new woods be defined or additional mods, and just reuses the wood sign image.

Tested on MTG and Mineclonia worlds' maps.

Copy link
Copy Markdown
Member

@BuckarooBanzay BuckarooBanzay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a bit repetitive but works for me 👍

@BuckarooBanzay BuckarooBanzay merged commit 8cbef9b into minetest-mapserver:master Apr 19, 2025
4 checks passed
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 14501569459

Details

  • 0 of 55 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.4%) to 27.399%

Changes Missing Coverage Covered Lines Changed/Added Lines %
mapobject/setup.go 0 55 0.0%
Files with Coverage Reduction New Missed Lines %
mapobject/setup.go 1 0.0%
Totals Coverage Status
Change from base Build 11784474570: -0.4%
Covered Lines: 968
Relevant Lines: 3533

💛 - Coveralls

@bgstack15 bgstack15 deleted the dev/add-mcl-signs branch September 10, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request mapobject:backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mineclone signs support

3 participants