-
Notifications
You must be signed in to change notification settings - Fork 6
[machine]:windows node setup #13
base: main
Are you sure you want to change the base?
[machine]:windows node setup #13
Conversation
| if err := b2dutils.CopyIsoToMachineDir(d.Boot2DockerURL, d.MachineName); err != nil { | ||
| return err | ||
|
|
||
| if mcnutils.ConfigGuest.GetGuestOS() == "windows" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be nice if the ConfigGuest type had a "IsWindows()" method that we reuse throughout this change. I know it's just a comparison against a string, but this type of comparison changes over time.
| } | ||
| } | ||
|
|
||
| log.Infof("Starting VM...") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a useful logging message we're removing. Could even enhance it a bit with info about the VM we're starting.
|
@bobsira Thankyou for the PR, I have tried this PR locally along with bobsira/minikube#4 , Looks good to me. Thanks |
|
Can you please open a PR against minikube instead, if you still want to continue with this? |
To test this PR follow the steps below
Prerequisites (local machine)
1) Prepare local modules (temporary local replace)
Open
go.modin your localminikuberepo and temporarily replace thegit.832008.xyz/docker/machinemodule with your localminikube-machinepath.Before (example upstream replacement)
github.com/docker/machine => github.com/minikube-machine/machine v0.0.0-20240815173309-ffb6b643c381Temporary local replace( use a Windows absolute path)
Important: This replace is only for local testing. Remove or revert it before committing/pushing.
2) Build minikube
From the minikube repo root build with make (repo uses make target)
You should now have minikube.exe in the repo out directory
3) Start a hybrid cluster (elevated PowerShell)
Start using the default (built-in) VHD
.\minikube.exe start --kubernetes-version=v1.33.0 -n 2 --node-os='[linux,windows]'Start using a custom VHD (remote or local)
--windows-vhd-url accepts remote URLs or local absolute paths:Remote
.\minikube.exe start --kubernetes-version=v1.32.3 -n 2 --node-os='[linux,windows]' --windows-vhd-url='https://<your-storage>/hybrid-minikube-windows-server.vhdx'Local path
.\minikube.exe start --kubernetes-version=v1.32.3 -n 2 --node-os='[linux,windows]' --windows-vhd-url='C:\vhd\hybrid-minikube-windows-server.vhdx'4) What to expect
kubectl get nodes -o wideshould show two nodes with OS labels: one linux, one windows.Setting up the cluster

Verify your cluster
