Use native fetch api

[hoikin]

Hello there,

Is that possible to use native fetch api if available instead of node-fetch?

[mistval]

Hi, that's a good question. I did some quick testing and it seems like it should be possible, but might not be straightforward. To confirm, you mean the new native NodeJS fetch API, right? Or browser?

[hoikin]

Hi mistval,

Yes, I refer to the node native fetch API. See would it be possible, thanks a lot!

https://nodejs.org/dist/latest-v18.x/docs/api/globals.html#fetch

[glensc]

I guess this is the way to do it:

• Support passing in a fetch object? #34

[mistval]

Yes that's true, implementing that would also offer a path to resolving this ask.

node-fetch-cache is pretty coupled to node-fetch at the moment (for example calling the constructor of node-fetch's Response class). Probably will need to refactor node-fetch-cache to have its own Response class which is more generic while being substitutable for responses from both node-fetch and the native fetch API in all the important ways (which is an important goal of this library, being drop-in replaceable for node-fetch).

[glensc]

I even had trouble matching types of node-fetch and node-fetch-cache with typescript!

loosely explained is that node-fetch returned fetch-like function with properties attached to the function. and node-fetch-cache returned object that have more functions than needed. (or maybe it was vice versa? )if needed I can dig up the errors.

[mistval]

Sure, I can imagine what you mean but it would be good to see what you're doing exactly. The response from node-fetch-cache should be assignable to the response type of node-fetch, but the fetch function itself might not be assignable to the type of node-fetch's fetch function, though I think it should be possible to make it so.

[glensc]

Looks like I've published the code, so you can just look at the result of the massive hack:

• https://github.com/glensc/comics-mailer/blob/90c29c38791139822cf96e3deb3550a806c59676/src/core/types.ts

it's used like this:

• https://github.com/glensc/comics-mailer/blob/90c29c38791139822cf96e3deb3550a806c59676/src/core/HttpClient.ts

the typing now works, but the problem is that it doesn't work in the environment I plan to run it (bun):

• Runtime TypeError with node-fetch-cache oven-sh/bun#8487

[brianjenkins94]

This wouldn't require a code change, just use tsup src/index.ts to build:

// tsup.config.ts
import { defineConfig } from "tsup";
import * as fs from "fs/promises";
import * as path from "path";

export default defineConfig({
    "bundle": true,
    "esbuildPlugins": [
        {
            "name": "replace-node-fetch",
            "setup": function(build) {
                build.onLoad({ "filter": /.*/ }, async function(args) {
                    const contents = (await fs.readFile(args.path, { "encoding": "utf8" }))
                        .replace(/const \{ NodeFetch(Request|Response)(, fetch)? \} = await getNodeFetch\(\);/gu, "")
                        .replace("export { getNodeFetch };", "")

                    return {
                        "contents": [
                            "//import { Request as NodeFetchRequest, Response as NodeFetchResponse } from \"node-fetch\";",
                            contents
                        ].join("\n"),
                        "loader": path.extname(args.path).substring(1)
                    };
                });
            }
        }
    ],
    "format": "esm",
    "treeshake": true
});

[mistval]

@brianjenkins94 It's not going to be that simple unfortunately, this package uses node-fetch in ways that can't be drop-in replaced with native fetch.