Fixed order in constructor of m_pathSampler#111
Open
joeylitalien wants to merge 1 commit intomitsuba-renderer:masterfrom
Open
Fixed order in constructor of m_pathSampler#111joeylitalien wants to merge 1 commit intomitsuba-renderer:masterfrom
joeylitalien wants to merge 1 commit intomitsuba-renderer:masterfrom
Conversation
|
Actually, the path sampler header and uses in instantiations are consistent. What needs to be fixed, is the inconsistent parameter name order in PathSampler.cpp (Otherwise, this pull request just introduces a different inconsistency) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the implementation of PSSMLT,
m_sensorSamplerandm_emitterSamplerare swapped. The object initialization form_pathSamplerdoes not follow thePathSampler's default constructor signature. You can check that this is the case if you run PSSMLT with unidirectional path tracing: only the emitter sampler is used. Unless this is done on purpose, it should be fixed.