Fix unable detect qt5 by using high version scons to build#163
Open
OmegaZhou wants to merge 1 commit intomitsuba-renderer:scons-python3from
Open
Fix unable detect qt5 by using high version scons to build#163OmegaZhou wants to merge 1 commit intomitsuba-renderer:scons-python3from
OmegaZhou wants to merge 1 commit intomitsuba-renderer:scons-python3from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I use Python3 and Scons-v4.3 to build the mitsuba, but was unable to detect the qt5 when building.
I try to get the exception from qt5.py, and I find that SCons.Warnings do not have the attribute of Warning
When I search the document of Scons-v4.0.1, I see the
Warningis inherited fromErrors.UserErrorand has subclassWarningOnByDefaultHowever, from version v4.1.0, I can't find the
Warningin the document, instead I find classSConsWarningis inherited fromErrors.UserErrorand has subclassWarningOnByDefaultSo I change the qt5.py so that it can run in high version Scons and keep it compatible with the low versions.