Skip to content

Keep assistant logo visible after generation#787

Merged
miurla merged 2 commits intomainfrom
feature/persist-logo-blink
Mar 22, 2026
Merged

Keep assistant logo visible after generation#787
miurla merged 2 commits intomainfrom
feature/persist-logo-blink

Conversation

@miurla
Copy link
Copy Markdown
Owner

@miurla miurla commented Mar 22, 2026

Summary

  • keep the assistant logo visible after the latest response finishes streaming
  • animate the logo eyes left/right only during generation
  • switch the post-generation logo state to brief random blinking instead of looping motion

Testing

  • bun typecheck

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 22, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
morphic Ready Ready Preview, Comment Mar 22, 2026 0:21am

@miurla miurla merged commit 3b05804 into main Mar 22, 2026
8 checks passed
@miurla miurla deleted the feature/persist-logo-blink branch March 22, 2026 00:22
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 07b94249f2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +94 to +95
const showAssistantLogo = Boolean(
latestSection && (isLoading || latestSection.assistantMessages.length > 0)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Suppress the idle logo for aborted or failed responses

If a user clicks Stop, or the stream errors after yielding any assistant tokens, status is no longer loading but latestSection.assistantMessages.length > 0 still keeps showAssistantLogo truthy. That makes an interrupted response look like a normal completed one, and for aborted streams it is especially misleading because lib/streaming/create-chat-stream-response.ts explicitly skips persisting isAborted responses, so the “completed” answer disappears on refresh.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant