Keep assistant logo visible after generation#787
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 07b94249f2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const showAssistantLogo = Boolean( | ||
| latestSection && (isLoading || latestSection.assistantMessages.length > 0) |
There was a problem hiding this comment.
Suppress the idle logo for aborted or failed responses
If a user clicks Stop, or the stream errors after yielding any assistant tokens, status is no longer loading but latestSection.assistantMessages.length > 0 still keeps showAssistantLogo truthy. That makes an interrupted response look like a normal completed one, and for aborted streams it is especially misleading because lib/streaming/create-chat-stream-response.ts explicitly skips persisting isAborted responses, so the “completed” answer disappears on refresh.
Useful? React with 👍 / 👎.
Summary
Testing