Conversation
demo/package.json
Outdated
| }, | ||
| "tns-android": { | ||
| "version": "3.4.0" | ||
| "version": "3.5.0-rc-2018.1.8.1" |
There was a problem hiding this comment.
@govi2010 Is the demo in any way tied to any fixes made on 3.5.0-rc-2018.1.8.1. I mean would it still run on the current stable version of 3.4.1?
There was a problem hiding this comment.
Yes it will run Ok with any version
There was a problem hiding this comment.
Okay. Very well then. 👍
| } | ||
| // if (!result.google.error || !result.facebook.error) { | ||
| // tabView.selectedIndex = 1; | ||
| // } |
There was a problem hiding this comment.
@govi2010 Was there any particular reason why lines 60 to 74 was commented out?
| permissions: ["r_basicprofile", "r_emailaddress"], | ||
| state: '', | ||
| redirectUri: "{{yourredirectURL}}" | ||
| } |
There was a problem hiding this comment.
@govi2010 Initialization parameters for google and facebook seems to have been removed here. Any reasons?
| viewModel.facebookAppId = androidResources.getString(org.nativescript.NativescriptSocialLoginDemo.R.string.facebook_app_id); | ||
| } | ||
| catch (e) { | ||
| viewModel.facebookAppId = androidResources.getString(com.giddh.accounts.R.string.facebook_app_id); |
There was a problem hiding this comment.
@govi2010 Did the appId for the demo app change from org.nativescript.NativescriptSocialLoginDemo to com.giddh.accounts?
There was a problem hiding this comment.
Sorry, my bad. I forgot to replace with original package id. I will Fix that.
|
I will fix this all issue soon.... may be tonight |
|
actually, I am not using this for LinkedIn login. Because Web token and Mobile Token are different for Linkedin. I already have a website and electron app using OAuth. When I pass the token to server and server retrieve user info. But you can not use mobile token at server side to retrieve user info. I end up using Webview directly in my project for linkedin. But this will be handy for users who want Mobile SDK Integration. |
demo/app/main-page.xml
Outdated
| <TabViewItem title="Buttons"> | ||
| <TabViewItem.view> | ||
| <StackLayout className="mjk-buttons"> | ||
| <Button text="logout" tap="{{ }}"> |
There was a problem hiding this comment.
@govi2010 There seems to be an issue here. The Button was created but never closed, probably missing a /.
There was a problem hiding this comment.
I know @jogboms. I was trying to implement logout button for google.
There was a problem hiding this comment.
Lets me make this work and complete this PR. Sorry for Delay but It too much work on my side.
| }, | ||
| "dependencies": { | ||
| "nativescript-social-login": "file:../src", | ||
| "nativescript-social-login-linkedin": "file:..\\src", |
There was a problem hiding this comment.
Is there any reason for changing the name of the package, seeing this change was not reflected in the demo implementation?
| logoutWithGoogle(callback: (result: Partial<ILoginResult>) => void) { | ||
| if (this._googleClient.isConnected()) | ||
| { | ||
| logoutWithGoogle(callback: (result: Partial<ILoginResult>) => void) { |
There was a problem hiding this comment.
@govi2010 usually though, when a new feature is added, its a requirement its implemented across both platforms. This seems like a pretty neat feature but pending when i could collaborate on this new feature, could you revert this feat on the PR so we can create a new PR for it later on so can it can be replicated across board for both platforms and for all providers?
jogboms
left a comment
jogboms
left a comment
There was a problem hiding this comment.
The changes made on this commit introduces a lot of conflicts.
- name
- repository.url
- author
- bugs
- homepage
2 participants
I am not android or ios developer. So for any mistake please guid me so i can fix it.
Right now In linkedin I am successfully getting access token which i need.
For IOS, I have used https://github.com/tonyli508/LinkedinSwift POD file
For Android i have used Official Linkedin SDK.