This repository was archived by the owner on Feb 2, 2022. It is now read-only.
Open
Conversation
dominik-hadl
suggested changes
Jul 7, 2017
dominik-hadl
left a comment
There was a problem hiding this comment.
Thanks for the changes, this will be a great addition!
There's just a few things that need to be fixed before we can merge this :)
- Remove @objc from declarations unless absolutely necessary (ie. for performSelector or timers..)
- Remove or fix commented out code. There's also no fixmes/todos so it will just get forgotten in the future and it looks bad in the code.
- Update travis to compile properly for Swift 4
- Can you please write a summary of what exactly has been changed and how? The current description and code changes are impossible to understand for anyone who doesn't know the codebase already.
Otherwise can't wait and will merge asap! 🎉
533d13a to
a4b9054
Compare
Added comments
Author
|
Changes: Instead of throwing an error when locating several declarations within one model, we now first extract the embedded model then recursively extract the remaining occurrences |
added 2 commits
July 11, 2017 16:44
Refactored embedded model parsing to using a new regex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not the prettiest string manipulation, but it seems to work with struct and final class