Merged
Conversation
CharlieFRuan
added a commit
that referenced
this pull request
Aug 12, 2024
### Changes - Reorganized internal code, which should have no affect on behaviors #536 - Bumped version of tokenizers-cpp to fix potential error `The global thread pool has not been initialized.` - For more, see mlc-ai/tokenizers-cpp#42 ### TVMjs - Still compiled at apache/tvm@1fcb620, no change
jingyi-zhao-01
pushed a commit
to jingyi-zhao-01/web-llm
that referenced
this pull request
Dec 8, 2024
This PR reorganizes `engine.ts` to keep it relatively more organized. - We move `getToolCallFromOutputMessage()` from `engine.ts` to `support.ts` since it does not depend on any engine-related fields and is stateless - We move `asyncLoadTokenizer()` from `engine.ts` to `cache_util.ts` for the same reason - For `engine.ts`, we break down the functions into sections
jingyi-zhao-01
pushed a commit
to jingyi-zhao-01/web-llm
that referenced
this pull request
Dec 8, 2024
### Changes - Reorganized internal code, which should have no affect on behaviors mlc-ai#536 - Bumped version of tokenizers-cpp to fix potential error `The global thread pool has not been initialized.` - For more, see mlc-ai/tokenizers-cpp#42 ### TVMjs - Still compiled at apache/tvm@1fcb620, no change
atebites-hub
pushed a commit
to atebites-hub/web-llm
that referenced
this pull request
Oct 4, 2025
This PR reorganizes `engine.ts` to keep it relatively more organized. - We move `getToolCallFromOutputMessage()` from `engine.ts` to `support.ts` since it does not depend on any engine-related fields and is stateless - We move `asyncLoadTokenizer()` from `engine.ts` to `cache_util.ts` for the same reason - For `engine.ts`, we break down the functions into sections
atebites-hub
pushed a commit
to atebites-hub/web-llm
that referenced
this pull request
Oct 4, 2025
### Changes - Reorganized internal code, which should have no affect on behaviors mlc-ai#536 - Bumped version of tokenizers-cpp to fix potential error `The global thread pool has not been initialized.` - For more, see mlc-ai/tokenizers-cpp#42 ### TVMjs - Still compiled at apache/tvm@1fcb620, no change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reorganizes
engine.tsto keep it relatively more organized.getToolCallFromOutputMessage()fromengine.tstosupport.tssince it does not depend on any engine-related fields and is statelessasyncLoadTokenizer()fromengine.tstocache_util.tsfor the same reasonchatCompletion()andcompletion()engine.ts, we break down the functions into sections:reload(),unload()_generate(),asyncGenerate(),interruptGenerate()generate()(deprecated),chatCompletion(),completion()support.tsas well. Currently these methods are in the MLCEngineInterface, and goes through the WebWorkerMLCEngine - MLCEngine message passing workflow