fix: build lib into separate lib directory#12
Merged
khvzak merged 1 commit intomlua-rs:mainfrom Jun 17, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason, having includes in a subdirectory of the directory containing the lib breaks compilation on Windows/MSVC (as used by lux, see #11 (comment)).
Moving the libs to a separate
libsubdirectory seems to fix this.I've tested this fix by adding my fork+branch as a dependency to lux and it seems to do the trick: lumen-oss/lux#801
(the nix build failures are because of the git dependency).