Updating the binding to support MMTk with upstream Julia#180
Merged
udesou merged 32 commits intommtk:upstream-ready/immixfrom Oct 18, 2024
Merged
Updating the binding to support MMTk with upstream Julia#180udesou merged 32 commits intommtk:upstream-ready/immixfrom
udesou merged 32 commits intommtk:upstream-ready/immixfrom
Conversation
…ia, which has MMTk as an external GC
…jl_small_typeof instead of internal version
…ges in the binding
…ic to stock Julia
qinsoon
reviewed
Oct 11, 2024
Member
qinsoon
left a comment
qinsoon
left a comment
There was a problem hiding this comment.
Do we plan to remove the julia folder and move the files to the Julia repo?
qinsoon
reviewed
Oct 17, 2024
Member
qinsoon
left a comment
qinsoon
left a comment
There was a problem hiding this comment.
Looks good. After removing the C source from the binding, and introducing bindgen to our build process, it is much cleaner.
qinsoon
approved these changes
Oct 18, 2024
Merged
udesou
added a commit
that referenced
this pull request
Oct 24, 2024
Backporting #180, merge with mmtk/julia#67.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
update-ready/immixto support its counterpart inmmtk/julia. It should enable MMTk to run with the latest upstream Julia, but currently supporting only non-moving immix. It also cleans up the binding code, removing the C files and moving it into the Julia repo (gc-mmtk.c). Finally, it removes the duplication that we had to use Bindgen, and instead generates the Rust bindings using abuild.rsfile.