Skip to content

chore(workflows): pin checkout v7.0.1 in all recipes, setup-node v6.4.0 in internal-npm (follow-up to #30) - #31

Merged
keith-mnemom merged 2 commits into
mainfrom
keith-follow-up/github-30-checkout-v701
Oct 21, 2026
Merged

keith-mnemom merged 2 commits into
mainfrom
keith-follow-up/github-30-checkout-v701

Conversation

@keith-mnemom

Copy link
Copy Markdown
Member

Follow-up to: #30 · items from keith-PR review at da009bb
Fixes: follow-up items only
Merge: HUMAN ONLY: .github/workflows/ is CI/workflow config (dependency pin bump). Both items name this path.

What: Moves every SHA-pinned actions/checkout to v7.0.1, and moves internal-npm-publish's setup-node to v6.4.0.
Why: Without this, three recipes stay on checkout v7.0.0, which has the fork-PR-check false positive. The two internal recipes also stay one major behind the public ones.
Impact: None until a caller bumps its mnemom/.github@<sha> pin. After that, its checkout runs v7.0.1 instead of v7.0.0 or v6.0.2.
Customer impact: None. CI-only change to reusable workflows.

Items:

  1. "checkout v7.0.1 (3d3c42e5) ... the better pin next time" → npm-publish.yml:54, pypi-publish.yml:53, security-scan.yml:47 @ 05fa821 pinned 9c091bb2 # v7.0.0. They now pin 3d3c42e5 # v7.0.1 (cbd2d98).
  2. "internal-npm-publish.yml:67,92 and internal-python-publish.yml:74 stay on checkout v6.0.2 / setup-node v6.2.0" → at 05fa821 these pinned de0fac2e / 6044e13b with bare # v6 comments. They now pin checkout 3d3c42e5 # v7.0.1 and setup-node 48b55a01 # v6.4.0, the same pins the public recipes use (33585f0).

Root cause: #30 copied Dependabot #23 exactly, so it pinned v7.0.0. #23 also predates the internal recipes.

Not changed on purpose: dependency-review.yml / hardening-sweep.yml float on checkout@v7, which already resolves to 3d3c42e5. internal-python-publish.yml:76 setup-python is already v7.0.0. The other items from #30 (provenance-audit failure, closing #23, reusable workflows having no test) are dispositioned on #30 as Needs a human.

Compatibility and rollout: Every caller pins mnemom/.github by SHA. internal-* callers: mnemom-packages (release/workflow_dispatch), mnemom-research-grade (push/workflow_dispatch), grant.mnemom (release/workflow_dispatch). None uses pull_request_target/workflow_run, so checkout v7's fork-PR block cannot fire. No checkout step passes with: inputs. The internal-npm setup-node inputs (node-version, registry-url) match what npm-publish.yml already uses on v6.4.0.

Rollback: revert is safe.

Verification:

  • git ls-remote https://github.com/actions/checkout refs/tags/v7.0.1 → 3d3c42e5aac5ba805825da76410c181273ba90b1 (same as refs/tags/v7). setup-node refs/tags/v6.4.0 → 48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e
  • actionlint .github/workflows/*.yml: on both base and head, the only finding is the same SC2086 info in the untouched dependabot-auto-merge.yml:66
  • grep -rn "de0fac2\|6044e13\|9c091bb" .github/ → no matches
  • No test exercises reusable workflows in this repo. The only check is default-setup CodeQL Analyze (actions)

Runtime parity: All jobs are runs-on: ubuntu-latest. Both actions declare using: node24. Workers/Azure: n/a.

Risks:

  • An internal publish fails on checkout v7 the next time a caller bumps its pin. Blast radius: one release publish, and a pin revert in that caller undoes it.

Proof after merge: On the first caller run after a pin bump, the "Run actions/checkout" log shows 3d3c42e5 and the step succeeds.

Could not verify: No reusable-workflow run at this head. That happens only when a caller bumps its pin.

🤖 Generated with Claude Code

keith-mnemom and others added 2 commits October 20, 2026 22:38
keith-PR review of #30 @ da009bb: "checkout v7.0.1 (3d3c42e5) fixes a
false-positive in the new fork-PR check ... the better pin next time".
Moves the three SHA-pinned checkouts (npm-publish, pypi-publish,
security-scan) from 9c091bb2 (v7.0.0) to 3d3c42e5 (v7.0.1), the SHA the
floating checkout@v7 already resolves to.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…setup-node v6.4.0 (follow-up to #30)

keith-PR review of #30 @ da009bb: "internal-npm-publish.yml:67,92 and
internal-python-publish.yml:74 stay on checkout v6.0.2 / setup-node
v6.2.0 (out of scope by design)". Brings them to the pins the public
recipes carry: checkout 3d3c42e5 (v7.0.1), setup-node 48b55a01 (v6.4.0),
and replaces the bare "# v6" comments with exact tags.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@keith-mnemom keith-mnemom left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From: keith-PR agent

Verdict: ✅ SAFE TO MERGE at head 33585f0bf491bae249b03176b9ffb37a51dea1a9 · human merge (.github/workflows/ is never-auto) · mark ready first (draft)

What it does: Moves every SHA-pinned checkout step in the org's shared publish and security-scan workflows to checkout 7.0.1 (from 7.0.0, or 6.0.2 in the two internal publish recipes), and moves the internal npm recipe's Node setup to 6.4.0, the version the public npm recipe already uses.

Why it's needed: #30 copied Dependabot's July proposal verbatim, so three recipes landed on checkout 7.0.0, whose new fork-PR safety check has a known false positive, and the two internal recipes, added after that proposal, were never bumped and sit a major version behind their public twins.

Why it's correct: Base 05fa8210 pins 9c091bb2 (v7.0.0) at npm-publish.yml:54, pypi-publish.yml:53, security-scan.yml:47; de0fac2e (v6.0.2) / 6044e13b (v6.2.0) at internal-npm-publish.yml:67,92, internal-python-publish.yml:74. Head pins 3d3c42e5 = refs/tags/v7.0.1 = refs/tags/v7, and 48b55a01 = refs/tags/v6.4.0; both action.yml declare using: node24. v7.0.0→v7.0.1 changes only src/input-helper.ts and src/git-command-manager.ts: the fork guard now runs only when repository/ref is set (actions/checkout#2518), and none of the five changed steps pass with:. No stale pin remains; floating @v7 elsewhere already resolves to 3d3c42e5. All 17 caller workflow files checked.

Risk: Medium: a shared scan or publish job fails at its checkout step on its next run.

  • security-scan.yml:47 breaks for the four @main callers (mcp, mnemom-reputation, mnemom-risk, reputation-check; all push/pull_request/schedule): ✘ no test; no CI exercises reusable workflows here. Noticed on their next run; revert is a clean undo. v7.0.0 is already live for them and v7.0.1 only removes a check.
  • Internal publish fails after a caller bumps its pin: ✘ no test. Checkout/setup-node run before any publish step, so it is a failed release, not a partial one; a caller pin revert undoes it. Current pins 80ef9826/7e5e87ad are untouched.
  • Public publish recipes: unaffected until bump; every caller pins 3b60e34e, b20e3a2e, or 3365cc79.
Evidence
  • Premise: exists on base (git show 05fa8210:.github/workflows/*); gh api repos/actions/checkout/tags maps de0fac2e→v6.0.2, setup-node 6044e13b→v6.2.0.
  • Callers & siblings: internal-npm: mnemom-packages publish.yml:241, mnemom-research-grade publish-trust-app.yml:91, grant.mnemom publish.yml:165; internal-python: mnemom-packages publish.yml:254; all release/push-tag/workflow_dispatch. security-scan: 7 codeql.yml callers, 4 on @main. npm/pypi-publish: 14 files, all SHA-pinned. No caller uses pull_request_target/workflow_run. setup-node v6.3.0/v6.4.0 changes do not touch the node-version/registry-url inputs the recipe passes.
  • Runtime: all jobs runs-on: ubuntu-latest; n/a for Workers/Azure.
  • Tests run: none exist; only check is default-setup CodeQL Analyze (actions) (run 39550753922), which parsed all workflow files clean.
  • CI: all 2 checks green, MERGEABLE/CLEAN, no review threads, no review gate. Closes the two checkout-v7.0.1 / internal-recipe follow-ups from the #30 review at da009bb6.

@keith-mnemom
keith-mnemom marked this pull request as ready for review October 21, 2026 18:55
@keith-mnemom
keith-mnemom merged commit 92da72b into main Oct 21, 2026
2 checks passed
@keith-mnemom
keith-mnemom deleted the keith-follow-up/github-30-checkout-v701 branch October 21, 2026 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant