Repository navigation
chore(workflows): pin checkout v7.0.1 in all recipes, setup-node v6.4.0 in internal-npm (follow-up to #30) - #31
Conversation
keith-PR review of #30 @ da009bb: "checkout v7.0.1 (3d3c42e5) fixes a false-positive in the new fork-PR check ... the better pin next time". Moves the three SHA-pinned checkouts (npm-publish, pypi-publish, security-scan) from 9c091bb2 (v7.0.0) to 3d3c42e5 (v7.0.1), the SHA the floating checkout@v7 already resolves to. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…setup-node v6.4.0 (follow-up to #30) keith-PR review of #30 @ da009bb: "internal-npm-publish.yml:67,92 and internal-python-publish.yml:74 stay on checkout v6.0.2 / setup-node v6.2.0 (out of scope by design)". Brings them to the pins the public recipes carry: checkout 3d3c42e5 (v7.0.1), setup-node 48b55a01 (v6.4.0), and replaces the bare "# v6" comments with exact tags. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
keith-mnemom
left a comment
There was a problem hiding this comment.
From: keith-PR agent
Verdict: ✅ SAFE TO MERGE at head 33585f0bf491bae249b03176b9ffb37a51dea1a9 · human merge (.github/workflows/ is never-auto) · mark ready first (draft)
What it does: Moves every SHA-pinned checkout step in the org's shared publish and security-scan workflows to checkout 7.0.1 (from 7.0.0, or 6.0.2 in the two internal publish recipes), and moves the internal npm recipe's Node setup to 6.4.0, the version the public npm recipe already uses.
Why it's needed: #30 copied Dependabot's July proposal verbatim, so three recipes landed on checkout 7.0.0, whose new fork-PR safety check has a known false positive, and the two internal recipes, added after that proposal, were never bumped and sit a major version behind their public twins.
Why it's correct: Base 05fa8210 pins 9c091bb2 (v7.0.0) at npm-publish.yml:54, pypi-publish.yml:53, security-scan.yml:47; de0fac2e (v6.0.2) / 6044e13b (v6.2.0) at internal-npm-publish.yml:67,92, internal-python-publish.yml:74. Head pins 3d3c42e5 = refs/tags/v7.0.1 = refs/tags/v7, and 48b55a01 = refs/tags/v6.4.0; both action.yml declare using: node24. v7.0.0→v7.0.1 changes only src/input-helper.ts and src/git-command-manager.ts: the fork guard now runs only when repository/ref is set (actions/checkout#2518), and none of the five changed steps pass with:. No stale pin remains; floating @v7 elsewhere already resolves to 3d3c42e5. All 17 caller workflow files checked.
Risk: Medium: a shared scan or publish job fails at its checkout step on its next run.
security-scan.yml:47breaks for the four@maincallers (mcp, mnemom-reputation, mnemom-risk, reputation-check; allpush/pull_request/schedule): ✘ no test; no CI exercises reusable workflows here. Noticed on their next run; revert is a clean undo. v7.0.0 is already live for them and v7.0.1 only removes a check.- Internal publish fails after a caller bumps its pin: ✘ no test. Checkout/setup-node run before any publish step, so it is a failed release, not a partial one; a caller pin revert undoes it. Current pins
80ef9826/7e5e87adare untouched. - Public publish recipes: unaffected until bump; every caller pins
3b60e34e,b20e3a2e, or3365cc79.
Evidence
- Premise: exists on base (
git show 05fa8210:.github/workflows/*);gh api repos/actions/checkout/tagsmapsde0fac2e→v6.0.2, setup-node6044e13b→v6.2.0. - Callers & siblings: internal-npm: mnemom-packages
publish.yml:241, mnemom-research-gradepublish-trust-app.yml:91, grant.mnemompublish.yml:165; internal-python: mnemom-packagespublish.yml:254; allrelease/push-tag/workflow_dispatch. security-scan: 7codeql.ymlcallers, 4 on@main. npm/pypi-publish: 14 files, all SHA-pinned. No caller usespull_request_target/workflow_run. setup-node v6.3.0/v6.4.0 changes do not touch thenode-version/registry-urlinputs the recipe passes. - Runtime: all jobs
runs-on: ubuntu-latest; n/a for Workers/Azure. - Tests run: none exist; only check is default-setup CodeQL
Analyze (actions)(run 39550753922), which parsed all workflow files clean. - CI: all 2 checks green, MERGEABLE/CLEAN, no review threads, no review gate. Closes the two checkout-v7.0.1 / internal-recipe follow-ups from the #30 review at
da009bb6.
Follow-up to: #30 · items from keith-PR review at da009bb
Fixes: follow-up items only
Merge: HUMAN ONLY:
.github/workflows/is CI/workflow config (dependency pin bump). Both items name this path.What: Moves every SHA-pinned
actions/checkoutto v7.0.1, and moves internal-npm-publish'ssetup-nodeto v6.4.0.Why: Without this, three recipes stay on checkout v7.0.0, which has the fork-PR-check false positive. The two internal recipes also stay one major behind the public ones.
Impact: None until a caller bumps its
mnemom/.github@<sha>pin. After that, its checkout runs v7.0.1 instead of v7.0.0 or v6.0.2.Customer impact: None. CI-only change to reusable workflows.
Items:
3d3c42e5) ... the better pin next time" →npm-publish.yml:54,pypi-publish.yml:53,security-scan.yml:47@ 05fa821 pinned9c091bb2# v7.0.0. They now pin3d3c42e5# v7.0.1 (cbd2d98).internal-npm-publish.yml:67,92andinternal-python-publish.yml:74stay on checkout v6.0.2 / setup-node v6.2.0" → at 05fa821 these pinnedde0fac2e/6044e13bwith bare# v6comments. They now pin checkout3d3c42e5# v7.0.1 and setup-node48b55a01# v6.4.0, the same pins the public recipes use (33585f0).Root cause: #30 copied Dependabot #23 exactly, so it pinned v7.0.0. #23 also predates the internal recipes.
Not changed on purpose:
dependency-review.yml/hardening-sweep.ymlfloat oncheckout@v7, which already resolves to3d3c42e5.internal-python-publish.yml:76setup-python is already v7.0.0. The other items from #30 (provenance-audit failure, closing #23, reusable workflows having no test) are dispositioned on #30 as Needs a human.Compatibility and rollout: Every caller pins
mnemom/.githubby SHA. internal-* callers: mnemom-packages (release/workflow_dispatch), mnemom-research-grade (push/workflow_dispatch), grant.mnemom (release/workflow_dispatch). None usespull_request_target/workflow_run, so checkout v7's fork-PR block cannot fire. No checkout step passeswith:inputs. The internal-npm setup-node inputs (node-version,registry-url) match whatnpm-publish.ymlalready uses on v6.4.0.Rollback: revert is safe.
Verification:
git ls-remote https://github.com/actions/checkout refs/tags/v7.0.1→3d3c42e5aac5ba805825da76410c181273ba90b1(same asrefs/tags/v7). setup-noderefs/tags/v6.4.0→48b55a011bda9f5d6aeb4c2d9c7362e8dae4041eactionlint .github/workflows/*.yml: on both base and head, the only finding is the same SC2086 info in the untoucheddependabot-auto-merge.yml:66grep -rn "de0fac2\|6044e13\|9c091bb" .github/→ no matchesAnalyze (actions)Runtime parity: All jobs are
runs-on: ubuntu-latest. Both actions declareusing: node24. Workers/Azure: n/a.Risks:
Proof after merge: On the first caller run after a pin bump, the "Run actions/checkout" log shows
3d3c42e5and the step succeeds.Could not verify: No reusable-workflow run at this head. That happens only when a caller bumps its pin.
🤖 Generated with Claude Code