fix: crash with --parallel and --retries both enabled#5173
Merged
JoshuaKGoldberg merged 2 commits intoAug 6, 2024
Conversation
JoshuaKGoldberg
changed the title
4 tasks
|
Can this please be merged soon? |
4 tasks
lennonnikolas
pushed a commit
to lennonnikolas/mocha
that referenced
this pull request
Jan 24, 2026
* test case: crash with --parallel and --retries both enabled * fix: crash with --parallel and --retries both enabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
this.parent.titlePath is not a functionduring parallel execution with retries #5170status: accepting prsOverview
Turns out there are no existing tests for the case of having both
--paralleland--retriesenabled. The problem is that the new circular-reference-breaking logic from #5032 was also being run on other properties inresult- not justresult.error.