Repository navigation
Minor refactoring for CI scripts - #2142
Merged
Merged
Conversation
jaisnan
reviewed
Jan 23, 2023
|
|
||
| python3 -m pip install "${PYTHON_DEPS[@]}" | ||
|
|
||
| SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )" |
Contributor
There was a problem hiding this comment.
Could you add a comment above this line explaining what it does if possible?
celinval
approved these changes
Jan 23, 2023
This was referenced Jan 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
This is a follow-up to @celinval's comment from #2087. Instead of having to call multiple installation scripts (CBMC, Viewer, and Kissat),
install_deps.shnow installs them, so one only needs to invoke one script to install all the dependencies.Resolved issues:
Related RFC:
Call-outs:
Testing:
How is this change tested? CI
Is this a refactor change? Yes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.