Skip to content

Minor refactoring for CI scripts - #2142

Merged
zhassan-aws merged 2 commits into
model-checking:mainfrom
zhassan-aws:refactor-ci
Jan 23, 2023
Merged

zhassan-aws merged 2 commits into
model-checking:mainfrom
zhassan-aws:refactor-ci

Conversation

@zhassan-aws

Copy link
Copy Markdown
Contributor

Description of changes:

This is a follow-up to @celinval's comment from #2087. Instead of having to call multiple installation scripts (CBMC, Viewer, and Kissat), install_deps.sh now installs them, so one only needs to invoke one script to install all the dependencies.

Resolved issues:

Related RFC:

Call-outs:

Testing:

  • How is this change tested? CI

  • Is this a refactor change? Yes

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@zhassan-aws
zhassan-aws requested a review from a team as a code owner January 23, 2023 17:37

python3 -m pip install "${PYTHON_DEPS[@]}"

SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"

@jaisnan jaisnan Jan 23, 2023 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment above this line explaining what it does if possible?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@jaisnan jaisnan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants