Skip to content

fix: add kissat to the nixos patchelf list - #2207

Merged
adpaco merged 2 commits into
model-checking:mainfrom
camshaft:kissat-nixos
Feb 13, 2023
Merged

adpaco merged 2 commits into
model-checking:mainfrom
camshaft:kissat-nixos

Conversation

@camshaft

Copy link
Copy Markdown
Contributor

Description of changes:

In #2087, kissat was added to the kani-verifier distribution bundle. However, the binary wasn't included in the NixOS list of binaries to patch with patchelf and results in it not being executable on that platform. This change simply adds it to the list.

Call-outs:

I wonder if we need a better mechanism of keeping the list of binaries we ship in sync?

Testing:

I tested it locally by running the patchelf command manually. After running it I was able to use the solver as expected.

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@camshaft
camshaft requested a review from a team as a code owner February 10, 2023 21:39

@zhassan-aws zhassan-aws left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants