Repository navigation
Report recursive calls in delayed UB analysis instead of overflowing the stack - #5184
Open
Tiramisu-Cake wants to merge 2 commits into
Open
Tiramisu-Cake wants to merge 2 commits into
Tiramisu-Cake wants to merge 2 commits into
Conversation
Tiramisu-Cake
marked this pull request as ready for review
November 16, 2026 20:31
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
-Z uninit-checks, the points-to analysis for delayed UB analyzes the body of every function a harness calls, with no check for calls that are already being analyzed. When a harness with delayed UB targets reaches a recursive function, the compiler overflows its stack.The analysis now keeps track of the functions in progress and reports a recursive call at its call site: "Kani does not support memory initialization checks across recursive calls."
Testing
tests/expected/uninit/recursive-delayed/recursive-delayed.rsreaches a recursive helper from a harness where a pointer cast creates a delayed UB target. Onmainthe compiler overflows its stack; with this change it reports the error above.repeated-calls.rscalls a helper twice in a row: an uninitialized read is still reported, and the initialized case verifies.Standard workflows on this head in my fork: run. The macOS 15 job did not get a runner and the perf job lost its runner, both also after a rerun.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.
Disclosure: this change and description were prepared with the help of AI assistants.