Skip to content

Report recursive calls in delayed UB analysis instead of overflowing the stack - #5184

Open
Tiramisu-Cake wants to merge 2 commits into
model-checking:mainfrom
Tiramisu-Cake:fix/delayed-ub-recursion
Open

Tiramisu-Cake wants to merge 2 commits into
model-checking:mainfrom
Tiramisu-Cake:fix/delayed-ub-recursion

Conversation

@Tiramisu-Cake

Copy link
Copy Markdown
Contributor

With -Z uninit-checks, the points-to analysis for delayed UB analyzes the body of every function a harness calls, with no check for calls that are already being analyzed. When a harness with delayed UB targets reaches a recursive function, the compiler overflows its stack.

The analysis now keeps track of the functions in progress and reports a recursive call at its call site: "Kani does not support memory initialization checks across recursive calls."

Testing

tests/expected/uninit/recursive-delayed/recursive-delayed.rs reaches a recursive helper from a harness where a pointer cast creates a delayed UB target. On main the compiler overflows its stack; with this change it reports the error above. repeated-calls.rs calls a helper twice in a row: an uninitialized read is still reported, and the initialized case verifies.

Standard workflows on this head in my fork: run. The macOS 15 job did not get a runner and the perf job lost its runner, both also after a rerun.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

Disclosure: this change and description were prepared with the help of AI assistants.

@github-actions github-actions Bot added Z-EndToEndBenchCI Tag a PR to run benchmark CI Z-CompilerBenchCI Tag a PR to run benchmark CI labels Nov 16, 2026
@Tiramisu-Cake
Tiramisu-Cake marked this pull request as ready for review November 16, 2026 20:31
@Tiramisu-Cake
Tiramisu-Cake requested review from a team as code owners November 16, 2026 20:31

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Z-CompilerBenchCI Tag a PR to run benchmark CI Z-EndToEndBenchCI Tag a PR to run benchmark CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant