Repository navigation
Upgrade Rust toolchain to nightly-2026-11-17 - #5188
Open
feliperodri wants to merge 1 commit into
Open
feliperodri wants to merge 1 commit into
feliperodri wants to merge 1 commit into
Conversation
- rustc removed Attribute::path_matches and Attribute::value_str: Kani now checks the path of tool attributes and reads their string values itself. - HumanReadableErrorType gained a no_graphics field. - The new TyKind::View (view types, which rustc's own codegen does not support yet) is reported as unsupported. - copysign, maximum_number_nsz and minimum_number_nsz are now generic over the float type, like ceil and sqrt before them: Kani keeps its own f32/f64 models for them. - MIR no longer allows projecting into SIMD types (MCP#838): the CustomMask test model copies itself instead of deriving Clone and Debug. - The pattern_type_macro feature gate was removed; pattern_type! is gated by pattern_types. - Fix the new clippy unnecessary_to_owned findings. Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades the toolchain from
nightly-2026-11-12tonightly-2026-11-17.Changes for the new toolchain
Attribute::path_matchesandAttribute::value_str.attributes.rsnow checks a tool attribute's path itself (attr_path_matches, the same test rustc used to do) and reads apath = "value"attribute's string throughvalue_lit(attr_value_str).HumanReadableErrorTypegained ano_graphicsfield.TyKind::View, a work-in-progress feature that rustc's own codegen and const-eval do not support yet (unimplemented!()). Kani reports it as unsupported in the two type matches intyp.rs, as it does forUnsafeBinder.copysign,maximum_number_nszandminimum_number_nszare now generic over the float type, asceil,sqrtand others became before. They joinGENERIC_FLOAT_INTRINSICS, so Kani keeps its own f32/f64 models; the six tests call the generic intrinsics.#[repr(simd)]types (MCP#838). The derivedClone/Debugof theCustomMasktest model inlibrary/kaniprojected into its field and made clippy hit an ICE in MIR validation; it now copies the whole value. All SIMD tests in the regression pass unchanged.pattern_type_macrowas removed;pattern_type!is gated bypattern_types. Four tests drop the old gate (a comment keeps the line numbers their expected output refers to)..contains(&"...".to_string())calls flagged by the newunnecessary_to_ownedfinding use.iter().any(..).Testing
On Linux with CBMC 6.11.0, in the Kani CI image:
cargo build-dev, the LLBC build,scripts/kani-fmt.sh --check, and both clippy commands of the format-check workflow pass.scripts/kani-regression.sh: every suite passes exceptscript-based-pre/compiler_defaults(needsjq) andscript-based-pre/cbmc_truncated_results(memory limit), which only fail in my container; the steps after the suites (codegen-firecracker.sh, thecargo-features-flagcheck, the-D warningsbuild) pass.scripts/kani-llbc-regression.shpasses.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.