Skip to content

Upgrade Rust toolchain to nightly-2026-11-17 - #5188

Open
feliperodri wants to merge 1 commit into
model-checking:mainfrom
feliperodri:toolchain-2026-11-17
Open

feliperodri wants to merge 1 commit into
model-checking:mainfrom
feliperodri:toolchain-2026-11-17

Conversation

@feliperodri

Copy link
Copy Markdown
Member

Upgrades the toolchain from nightly-2026-11-12 to nightly-2026-11-17.

Changes for the new toolchain

  • Attributes. rustc removed Attribute::path_matches and Attribute::value_str. attributes.rs now checks a tool attribute's path itself (attr_path_matches, the same test rustc used to do) and reads a path = "value" attribute's string through value_lit (attr_value_str).
  • Diagnostics. HumanReadableErrorType gained a no_graphics field.
  • View types. rustc added TyKind::View, a work-in-progress feature that rustc's own codegen and const-eval do not support yet (unimplemented!()). Kani reports it as unsupported in the two type matches in typ.rs, as it does for UnsafeBinder.
  • Float intrinsics. copysign, maximum_number_nsz and minimum_number_nsz are now generic over the float type, as ceil, sqrt and others became before. They join GENERIC_FLOAT_INTRINSICS, so Kani keeps its own f32/f64 models; the six tests call the generic intrinsics.
  • SIMD types. MIR no longer allows field projections into #[repr(simd)] types (MCP#838). The derived Clone/Debug of the CustomMask test model in library/kani projected into its field and made clippy hit an ICE in MIR validation; it now copies the whole value. All SIMD tests in the regression pass unchanged.
  • Feature gates. pattern_type_macro was removed; pattern_type! is gated by pattern_types. Four tests drop the old gate (a comment keeps the line numbers their expected output refers to).
  • Clippy. Nine .contains(&"...".to_string()) calls flagged by the new unnecessary_to_owned finding use .iter().any(..).

Testing

On Linux with CBMC 6.11.0, in the Kani CI image:

  • cargo build-dev, the LLBC build, scripts/kani-fmt.sh --check, and both clippy commands of the format-check workflow pass.
  • scripts/kani-regression.sh: every suite passes except script-based-pre/compiler_defaults (needs jq) and script-based-pre/cbmc_truncated_results (memory limit), which only fail in my container; the steps after the suites (codegen-firecracker.sh, the cargo-features-flag check, the -D warnings build) pass.
  • scripts/kani-llbc-regression.sh passes.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

- rustc removed Attribute::path_matches and Attribute::value_str: Kani now checks the
  path of tool attributes and reads their string values itself.
- HumanReadableErrorType gained a no_graphics field.
- The new TyKind::View (view types, which rustc's own codegen does not support yet) is
  reported as unsupported.
- copysign, maximum_number_nsz and minimum_number_nsz are now generic over the float
  type, like ceil and sqrt before them: Kani keeps its own f32/f64 models for them.
- MIR no longer allows projecting into SIMD types (MCP#838): the CustomMask test model
  copies itself instead of deriving Clone and Debug.
- The pattern_type_macro feature gate was removed; pattern_type! is gated by
  pattern_types.
- Fix the new clippy unnecessary_to_owned findings.

Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
@feliperodri
feliperodri requested review from a team as code owners November 17, 2026 19:33
@feliperodri feliperodri added the [C] Internal Tracks some internal work. I.e.: Users should not be affected. label Nov 17, 2026
@github-actions github-actions Bot added Z-EndToEndBenchCI Tag a PR to run benchmark CI Z-CompilerBenchCI Tag a PR to run benchmark CI labels Nov 17, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[C] Internal Tracks some internal work. I.e.: Users should not be affected. Z-CompilerBenchCI Tag a PR to run benchmark CI Z-EndToEndBenchCI Tag a PR to run benchmark CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants