Conversation
pcarleton
force-pushed
the
pcarleton/cimd
branch
from
db29715 to
2ec3e36
Compare
pcarleton
force-pushed
the
pcarleton/cimd
branch
from
2ec3e36 to
a1d6d5d
Compare
commit: |
Merged
9 tasks
mattzcarey
reviewed
Nov 19, 2025
Comment on lines
3
to
7
| import { Client } from '@modelcontextprotocol/sdk/client/index.js'; | ||
| import { StreamableHTTPClientTransport } from '@modelcontextprotocol/sdk/client/streamableHttp.js'; | ||
| import { withOAuthRetry } from './helpers/withOAuthRetry.js'; | ||
| import { runAsCli } from './helpers/cliRunner.js'; | ||
| import { logger } from './helpers/logger.js'; |
Contributor
There was a problem hiding this comment.
nit: .js extension is not needed with tsx
mattzcarey
reviewed
Nov 19, 2025
Comment on lines
21
to
25
| const oauthFetch = withOAuthRetry( | ||
| 'test-auth-client-no-cimd', | ||
| new URL(serverUrl) | ||
| // Missing: handle401, clientMetadataUrl | ||
| )(fetch); |
Contributor
There was a problem hiding this comment.
as a user am I expected to understand what this does? Like is this a learning moment for me. If so I think this method could be clearer.
Member
Author
There was a problem hiding this comment.
yea the readability is a bit busted here for now. we need to upstream some things to the withOauth middleware in typescript and then refactor. for now i think this will be a little gross.
mattzcarey
approved these changes
Nov 19, 2025
Contributor
mattzcarey
left a comment
mattzcarey
left a comment
There was a problem hiding this comment.
Looks good to me. Couple of comments for readability
Address review feedback: expanded comments to better explain what CIMD is, why this client is non-compliant, and what behavior it's testing. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
tsx doesn't require .js extensions for TypeScript imports. Keeps .js for @modelcontextprotocol/sdk imports as those are external packages. Also improves auth-test-no-cimd.ts documentation for clarity. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Waiting on typescript-sdk PR #1127 for CIMD support. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Integrate new discovery-metadata.ts from main (replaces basic-dcr/basic-metadata) - Keep CIMD scenario from this branch - Apply .js extension removal to discovery-metadata imports 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
partially addresses #34
depends on typescript sdk change here:
modelcontextprotocol/typescript-sdk#1127