Update Copilot instructions for MTP#1012
Closed
Youssef1313 wants to merge 1 commit intomodelcontextprotocol:mainfrom
Closed
Update Copilot instructions for MTP#1012Youssef1313 wants to merge 1 commit intomodelcontextprotocol:mainfrom
Youssef1313 wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
halter73
reviewed
Nov 21, 2025
| - Dispose resources properly (servers, clients, transports) using `IDisposable` or `await using` | ||
| - Run tests with: `dotnet test --filter '(Execution!=Manual)'` | ||
| - Run tests with: `dotnet test --filter-not-trait 'Execution=Manual'` | ||
| - Valid test filter switches include: `--filter-class`, `--filter-not-class`, `--filter-method`, `--filter-not-method`, `--filter-namespace`, `--filter-not-namespace`, `--filter-not-trait`, `--filter-trait`. The switches `--filter-class` and `--filter-method` expect fully qualified names, unless a filter is used as a prefix like `--filter-class "*.SomeClassName"` or `--filter-method "*.SomeMethodName"`. These switches can be repeated to run tests on multiple classes or methods at once, e.g., `--filter-method "*.SomeMethodName1" --filter-method "*.SomeMethodName2"`. |
Contributor
There was a problem hiding this comment.
I did merge #1011, so we'll probably want to include the reversion of that in this PR. Additionally, I think we should call out --project is necessary for specifying specific test projects.
Suggested change
| - Valid test filter switches include: `--filter-class`, `--filter-not-class`, `--filter-method`, `--filter-not-method`, `--filter-namespace`, `--filter-not-namespace`, `--filter-not-trait`, `--filter-trait`. The switches `--filter-class` and `--filter-method` expect fully qualified names, unless a filter is used as a prefix like `--filter-class "*.SomeClassName"` or `--filter-method "*.SomeMethodName"`. These switches can be repeated to run tests on multiple classes or methods at once, e.g., `--filter-method "*.SomeMethodName1" --filter-method "*.SomeMethodName2"`. | |
| - Valid test filter switches include: `--filter-class`, `--filter-not-class`, `--filter-method`, `--filter-not-method`, `--filter-namespace`, `--filter-not-namespace`, `--filter-not-trait`, `--filter-trait`. The switches `--filter-class` and `--filter-method` expect fully qualified names, unless a filter is used as a prefix like `--filter-class "*.SomeClassName"` or `--filter-method "*.SomeMethodName"`. These switches can be repeated to run tests on multiple classes or methods at once, e.g., `--filter-method "*.SomeMethodName1" --filter-method "*.SomeMethodName2"`. | |
| - To specify a specific test project to run, you must always use the `--project` switch. For example, `dotnet test --project <path to test project directory or .csproj file> --filter-not-trait 'Execution=Manual'`. |
I'm not sure if there are more incompatibilities, but it would be better to avoid any breaking changes to the dotnet test cli interface to begin with.
Contributor
|
I'm closing this since we reverted the update to xunit.v3.mtp-v2. We can update the copilot instructions once we try it again, but I hope that we can avoid the breaking changes to the cli interface altogether. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context