Fixed radio/checkbox return values in getAllFieldsTypes()#383
Merged
modesty merged 6 commits intomodesty:masterfrom May 23, 2025
Merged
Fixed radio/checkbox return values in getAllFieldsTypes()#383modesty merged 6 commits intomodesty:masterfrom
modesty merged 6 commits intomodesty:masterfrom
Conversation
modesty
reviewed
Apr 5, 2025
modesty
approved these changes
May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously field values were not properly returned in getFieldBase() for checkbox and radio buttons. the "value" return was either empty for checkboxes and in each radio button group you would get a return value for each radio button and no indication which one was checked.
Old output:
Fixed output:
Sample file PDF:
Created with libre office writer
commit.pdf