fix: move package manager version from engines to devEngines#387
Merged
modesty merged 1 commit intomodesty:masterfrom May 23, 2025
Merged
fix: move package manager version from engines to devEngines#387modesty merged 1 commit intomodesty:masterfrom
engines to devEngines#387modesty merged 1 commit intomodesty:masterfrom
Conversation
modesty
requested changes
May 23, 2025
Owner
modesty
left a comment
modesty
left a comment
There was a problem hiding this comment.
I see the need to remove npm versions to support customized build or CI/CD. But not a fan to add non-standard or tool-specific properties like devEngine + packageManager. Which tool requires this change?
| "npm": ">=10.8.2" | ||
| "node": ">=20.18.0" | ||
| }, | ||
| "devEngines": { |
Owner
There was a problem hiding this comment.
devEngines: non-standard props, which tool recognizes it ?
Contributor
Author
There was a problem hiding this comment.
@modesty devEngines is standard. See my PR description. npm supports it
Owner
There was a problem hiding this comment.
thought it was a proposal only, now I see npm/cli#7766 is merged last October. thanks
modesty
approved these changes
May 23, 2025
modesty
force-pushed
the
styfle/fix-devEngines-npm
branch
from
a5db670 to
5a58e94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes sure that
npmis only enforced for developers in this repo but once published to npm, consumers can use whatever package manager they wish.See the docs here: