Skip to content

fix: use unix path separators in makefiles#271

Merged
jdhughes-dev merged 1 commit intomodflowpy:developfrom
wpbonelli:pathsep
Mar 27, 2026
Merged

fix: use unix path separators in makefiles#271
jdhughes-dev merged 1 commit intomodflowpy:developfrom
wpbonelli:pathsep

Conversation

@wpbonelli
Copy link
Copy Markdown
Member

There is a conversion to Unix path separators on L1349 but then calling relpath() restores Windows separators again. Add another conversion so generated makefiles consistently use Unix path separators, even when generated on Windows.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.130%. Comparing base (6d55d09) to head (0c6a07a).
⚠️ Report is 9 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##           develop      #271       +/-   ##
=============================================
+ Coverage   80.073%   80.130%   +0.056%     
=============================================
  Files           20        20               
  Lines         3523      3523               
=============================================
+ Hits          2821      2823        +2     
+ Misses         702       700        -2     
Files with missing lines Coverage Δ
pymake/pymake_base.py 85.971% <100.000%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jdhughes-dev jdhughes-dev merged commit 98abe3a into modflowpy:develop Mar 27, 2026
12 checks passed
@wpbonelli wpbonelli deleted the pathsep branch March 27, 2026 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants