docs: update README badges layout and add Version badge#16868
docs: update README badges layout and add Version badge#16868Ibochkarev wants to merge 3 commits intomodxcms:3.xfrom
Conversation
- Split badge links onto separate lines for readability - Point Build Status to ci.yml workflow - Add Version badge (GitHub tag)
| [](https://github.com/modxcms/revolution/tags) | ||
| [](https://app.codecov.io/github/modxcms/revolution) | ||
| [](https://github.com/modxcms/revolution/graphs/contributors) | ||
| [](https://modx.org) |
There was a problem hiding this comment.
Maybe replace with this? See here: https://community.modx.com/t/reorganise-the-community-discussion-forum-github-discussions-and-slack/8979/6
https://img.shields.io/discourse/posts?server=https%3A%2F%2Fcommunity.modx.com%2F&style=flat&logo=discourse&label=MODX%20Community
There was a problem hiding this comment.
I'd keep Slack, it's still in active use even if your points about in-depth discussions being better on the forum is valid.
There was a problem hiding this comment.
Perhaps we should add both until I can convince @Mark-H that Slack is not the right choice for the future ❤️
There was a problem hiding this comment.
Is there any downside to having both?
Code ReviewSummary Updates README.md badges layout: splits the single-line badge string into separate lines for readability, adds a Version badge (GitHub tag) and a Support MODX badge (Open Collective), and updates the Twitter badge to use the X logo. Assessment Simple documentation improvement. Badges on separate lines improve readability of the raw markdown. The new badges (Version, Support) provide useful project information. The Twitter-to-X logo update is current. Verdict: Approve |
mkschell
left a comment
mkschell
left a comment
There was a problem hiding this comment.
Visually confirmed. Docs-only change. Badge reformatting and CI URL fix are welcome. Compromise reached re: Slack & Community badges.
5 participants
What does it do?
Why is it needed?
Improves readability of the badge block and keeps the Build Status link correct; the Version badge provides quick access to the current release tag.
How to test
Open
README.mdin the repo and confirm badges are on separate lines, Build Status links to the correct CI workflow, and the Version badge displays the tag.Related issue(s)/PR(s)
None.