fix(iad-746): added idleTimeout and increased resources.requests for ML waypoint#953
Open
geka-evk wants to merge 2 commits intofeature/storage-clusterfrom
Open
fix(iad-746): added idleTimeout and increased resources.requests for ML waypoint#953geka-evk wants to merge 2 commits intofeature/storage-clusterfrom
geka-evk wants to merge 2 commits intofeature/storage-clusterfrom
Conversation
geka-evk
requested review from
PaulGregoryBaker,
bushjames,
dfry,
elnyry-sam-k,
kalinkrustev,
shashi165,
sijo5722-2021 and
vijayg10
as code owners
There was a problem hiding this comment.
Pull request overview
This PR addresses issue IAD-746 by adding connection pool timeout configurations and resource allocations for the Mojaloop service ingress waypoint. The changes optimize waypoint behavior by reducing idle connection timeout from the default 1 hour to 4 seconds and TCP connect timeout from 10 seconds to 5 seconds, while also ensuring adequate CPU and memory resources are allocated.
Changes:
- Added DestinationRule to configure connection pool timeouts for waypoint traffic in the mojaloop namespace
- Added resource requests (300m CPU, 256Mi memory) and limits (2 CPU, 1Gi memory) for global waypoint configuration
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| terraform/gitops/generate-files/templates/mojaloop/istio-config.yaml.tpl | Adds DestinationRule with connection pool settings (4s idleTimeout, 5s connectTimeout) for all services in mojaloop namespace |
| terraform/gitops/generate-files/templates/istio/istio-main/values-istio-istiod.yaml.tpl | Configures waypoint resources with 300m/256Mi requests and 2 CPU/1Gi limits |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.