[ReactDebugTools] wrap uncaught error from rendering user's component#1
Closed
mondaychen wants to merge 1 commit intocustom_error_debug_tools_1from
Closed
[ReactDebugTools] wrap uncaught error from rendering user's component#1mondaychen wants to merge 1 commit intocustom_error_debug_tools_1from
mondaychen wants to merge 1 commit intocustom_error_debug_tools_1from
Conversation
mondaychen
force-pushed
the
custom_error_debug_tools_1
branch
from
a11680b to
60cb32b
Compare
mondaychen
force-pushed
the
custom_error_debug_tools_2
branch
2 times, most recently
from
5146d90 to
dad75d3
Compare
mondaychen
force-pushed
the
custom_error_debug_tools_2
branch
from
dad75d3 to
a1bec07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds ability to detect error thrown from user's code, and wrap it inside an error with custom name, so Dev Tools is able to caught it and show custom error view.
This is to unblock #2
How did you test this change?
I'm testing it with a user's code from facebook#24096