DOCS-13871 Add REPL output to serverStatus command#5873
Merged
jeff-allen-mongo merged 1 commit intomongodb:masterfrom Sep 24, 2021
Merged
Conversation
Collaborator
jeff-allen-mongo
left a comment
jeff-allen-mongo
left a comment
There was a problem hiding this comment.
Just a couple questions before merge.
source/release-notes/5.0.txt
Outdated
|
|
||
| Repl | ||
| - :serverstatus:`repl` now includes a | ||
| :ref:`primaryOnlyServices<server-status-repl>` document which |
Collaborator
There was a problem hiding this comment.
Two things:
- Should this go into the "Replication Metrics" section above this one, rather than creating a new "Repl" section?
- Should we link directly to the "primaryOnlyServices" document? As in:
:serverstatus:`~repl.primaryOnlyServices`
The tilde at the beginning trims everything before the field name, so it should render as "primaryOnlyServices" rather than "repl.primaryOnlyServices".
Collaborator
There was a problem hiding this comment.
This should be "document 'that' contains", not 'which'.
Contributor
Author
There was a problem hiding this comment.
I updated the link and the "which" -> "that", as for the repl output I feel it is more appropriate to leave it as is I feel like this would have come out in TR if it were not the case. I attached a copy of serverStatus output to the ticket where metrics shows under a different document hierarchy.
ianf-mongodb
force-pushed
the
DOCS-13871-add-repl-output-to-serverStatus-section
branch
from
1723f92 to
e0788bb
Compare
mongo-cr-bot
pushed a commit
that referenced
this pull request
Jan 18, 2024
…Notes (#5604) (#5873) * DOCSP-35017 Add vm.force_cgroup_v2_swappiness recommendation to Prod Notes * ES suggestions * note placement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.