Fix test that randomly crashes#3464
Merged
GromNaN merged 1 commit intomongodb:5.5from Dec 9, 2025
Merged
Conversation
1) MongoDB\Laravel\Tests\SchemaTest::testGetTables Failed asserting that 40960 matches expected 8192.
There was a problem hiding this comment.
Pull request overview
This PR fixes a flaky test in SchemaTest::testGetTables that was failing intermittently due to a strict equality assertion on a collection size value that can vary.
Key Changes:
- Replaced strict equality assertion with a minimum threshold check for collection size validation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Closed
alcaeus
approved these changes
Dec 9, 2025
Member
alcaeus
left a comment
alcaeus
left a comment
There was a problem hiding this comment.
LGTM with a nit about being even more defensive, but this works just fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test is inconsistently crashing: