MONGOID-4889 Optimize batch assignment of embedded documents (backport to 9.0)#6010
Merged
jamis merged 1 commit intomongodb:9.0-stablefrom Aug 19, 2025
Merged
MONGOID-4889 Optimize batch assignment of embedded documents (backport to 9.0)#6010jamis merged 1 commit intomongodb:9.0-stablefrom
jamis merged 1 commit intomongodb:9.0-stablefrom
Conversation
…#6008) * MONGOID-4889 Optimize batch assignment of embedded documents * rubocop appeasement * simplify some refactoring artifacts * improve the name of the extracted method
comandeo-mongo
approved these changes
Aug 19, 2025
This was referenced Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Backported to 9.0-stable)
When associating multiple embedded documents in a single assignment, the existing code was inefficiently looping over all records repeatedly, resulting in a significant performance impact. This PR attempts to minimize the number of loops needed to accomplish the same thing, while keeping the ordering of callbacks the same and otherwise attempting to not break backward compatibility.
To test the performance of this PR, the following benchmark (from MONGOID-4889) was used:
With the previous implementation, the timings were abyssmal:
Things look much better with the optimized implementation: