MONGOID-5895 Make Reload Properly Update new_record #6034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt, but set the ID to an existing one
jamis
changed the title
jamis
approved these changes
Sep 9, 2025
Contributor
|
Thank you for the patch! 👍 |
Contributor
Author
|
More than happy to help. Thanks for making this a breeze! Do you have a release cadence for new versions, or is it "when it's ready" schedule? |
Contributor
|
@mmrlivingstone there's no official cadence, just "when it's ready." That said, we recently updated our release infrastructure to make it simpler to cut new releases, and we're trying to release more regularly. I'm hopeful this'll see the light of day in a week, two at the outside. |
jamis
pushed a commit
to jamis/mongoid
that referenced
this pull request
Sep 15, 2025
* Ensure reload properly handles instances where we create a new document, but set the ID to an existing one * Fix misplaced spec
jamis
added a commit
that referenced
this pull request
Sep 17, 2025
* Ensure reload properly handles instances where we create a new document, but set the ID to an existing one * Fix misplaced spec Co-authored-by: Matthew Livingstone <matthew.livingstone@clio.com>
Contributor
|
@mmrlivingstone -- Mongoid 9.0.8 has been released with this fix. Thank you for the patch, and for your patience! |
Contributor
Author
|
@jamis Thanks for the incredibly quick turn around on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've run into an issue when reloading a document which has had it's ID set to one that matches the value of an existing document.
Right now, when
.reloadis called in these circumstances, the data is pulled from the database, but the document does not update it'snew_recordvalue tofalse. This results in errors when trying to save, as Mongoid attempts to insert the document instead of updating the existing one.It's easy to reproduce with something like the pseudo-code below (the new specs also show this)